Checkstyle Results

The following document contains the results of Checkstyle 5.7. 

Summary

Files	Info	Warnings	Errors
7	24	9	62

Files

File	I	W	E
org/apache/archiva/metadata/repository/jcr/JcrConstants.java	24	0	5
org/apache/archiva/metadata/repository/jcr/JcrMetadataRepository.java	0	0	1
org/apache/archiva/metadata/repository/jcr/JcrMetadataRepositoryTest.java	0	0	1
org/apache/archiva/metadata/repository/jcr/JcrRepositorySession.java	0	3	28
org/apache/archiva/metadata/repository/jcr/JcrRepositorySessionFactory.java	0	6	25
org/apache/archiva/metadata/repository/jcr/OakRepositoryFactory.java	0	0	1
org/apache/archiva/metadata/repository/stats/JcrRepositoryStatisticsGatheringTest.java	0	0	1

Rules

Category	Rule	Violations	Severity
blocks	LeftCurly option: "nl"	16	Error
	RightCurly option: "alone"	3	Error
design	InterfaceIsType	1	Error
imports	AvoidStarImport	1	Error
	UnusedImports	6	Error
javadoc	JavadocMethod scope: "protected"	9	Warning
	JavadocVariable scope: "protected"	24	Info
naming	ConstantName	1	Error
sizes	LineLength max: "120" ignorePattern: "@version|@see|@todo|TODO"	2	Error
whitespace	ParenPad option: "space"	24	Error
	WhitespaceAfter	2	Error
	WhitespaceAround	2	Error

Details

org/apache/archiva/metadata/repository/jcr/JcrConstants.java

Severity	Category	Rule	Message	Line
Error	imports	UnusedImports	Unused import - java.time.ZoneId.	22
Error	design	InterfaceIsType	interfaces should describe a type and hence have methods.	29
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	34
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	35
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	36
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	37
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	38
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	39
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	40
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	41
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	42
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	43
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	44
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	45
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	46
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	47
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	48
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	49
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	50
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	51
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	52
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	53
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	54
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	55
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	56
Error	sizes	LineLength	Line is longer than 120 characters (found 224).	59
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	59
Error	whitespace	WhitespaceAfter	',' is not followed by whitespace.	59
Error	whitespace	WhitespaceAfter	',' is not followed by whitespace.	59

org/apache/archiva/metadata/repository/jcr/JcrMetadataRepository.java

Severity	Category	Rule	Message	Line
Error	extension	TreeWalker	Got an exception - expecting EOF, found 'if'	495

org/apache/archiva/metadata/repository/jcr/JcrMetadataRepositoryTest.java

Severity	Category	Rule	Message	Line
Error	extension	TreeWalker	Got an exception - expecting EOF, found 'Session'	152

org/apache/archiva/metadata/repository/jcr/JcrRepositorySession.java

Severity	Category	Rule	Message	Line
Error	naming	ConstantName	Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.	40
Error	sizes	LineLength	Line is longer than 120 characters (found 128).	45
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	45
Error	whitespace	ParenPad	')' is not preceded with whitespace.	45
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	52
Error	blocks	LeftCurly	'{' should be on a new line.	52
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	56
Error	blocks	LeftCurly	'{' should be on a new line.	56
Error	whitespace	ParenPad	'(' is not followed by whitespace.	70
Error	whitespace	ParenPad	')' is not preceded with whitespace.	70
Error	blocks	LeftCurly	'{' should be on a new line.	70
Error	blocks	LeftCurly	'{' should be on a new line.	113
Error	blocks	LeftCurly	'{' should be on a new line.	114
Error	whitespace	ParenPad	'(' is not followed by whitespace.	115
Error	whitespace	ParenPad	')' is not preceded with whitespace.	115
Error	blocks	RightCurly	'}' should be alone on a line.	116
Error	whitespace	ParenPad	'(' is not followed by whitespace.	116
Error	whitespace	ParenPad	')' is not preceded with whitespace.	116
Error	blocks	LeftCurly	'{' should be on a new line.	116
Error	whitespace	ParenPad	'(' is not followed by whitespace.	117
Error	whitespace	ParenPad	')' is not preceded with whitespace.	117
Error	blocks	LeftCurly	'{' should be on a new line.	122
Error	blocks	LeftCurly	'{' should be on a new line.	123
Error	whitespace	ParenPad	'(' is not followed by whitespace.	124
Error	whitespace	ParenPad	')' is not preceded with whitespace.	124
Error	blocks	RightCurly	'}' should be alone on a line.	125
Error	whitespace	ParenPad	'(' is not followed by whitespace.	125
Error	whitespace	ParenPad	')' is not preceded with whitespace.	125
Error	blocks	LeftCurly	'{' should be on a new line.	125
Error	whitespace	ParenPad	'(' is not followed by whitespace.	126
Error	whitespace	ParenPad	')' is not preceded with whitespace.	126

org/apache/archiva/metadata/repository/jcr/JcrRepositorySessionFactory.java

Severity	Category	Rule	Message	Line
Error	imports	UnusedImports	Unused import - org.apache.archiva.metadata.model.MetadataFacet.	22
Error	imports	UnusedImports	Unused import - org.apache.archiva.metadata.model.MetadataFacetFactory.	23
Error	imports	AvoidStarImport	Using the '.*' form of import should be avoided - org.apache.archiva.metadata.repository.*.	24
Error	imports	UnusedImports	Unused import - org.springframework.context.ApplicationContext.	30
Error	imports	UnusedImports	Unused import - java.util.HashMap.	40
Error	imports	UnusedImports	Unused import - java.util.Map.	41
Error	blocks	LeftCurly	'{' should be on a new line.	82
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	86
Error	whitespace	WhitespaceAround	'!=' is not preceded with whitespace.	90
Error	whitespace	WhitespaceAround	'!=' is not followed by whitespace.	90
Error	blocks	LeftCurly	'{' should be on a new line.	105
Error	blocks	RightCurly	'}' should be alone on a line.	107
Error	whitespace	ParenPad	'(' is not followed by whitespace.	107
Error	whitespace	ParenPad	')' is not preceded with whitespace.	107
Error	blocks	LeftCurly	'{' should be on a new line.	107
Error	whitespace	ParenPad	'(' is not followed by whitespace.	108
Error	whitespace	ParenPad	')' is not preceded with whitespace.	108
Error	whitespace	ParenPad	'(' is not followed by whitespace.	109
Error	whitespace	ParenPad	')' is not preceded with whitespace.	109
Error	whitespace	ParenPad	')' is not preceded with whitespace.	112
Error	blocks	LeftCurly	'{' should be on a new line.	112
Error	blocks	LeftCurly	'{' should be on a new line.	127
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	132
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	138
Error	whitespace	ParenPad	'(' is not followed by whitespace.	138
Error	whitespace	ParenPad	')' is not preceded with whitespace.	138
Error	blocks	LeftCurly	'{' should be on a new line.	138
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	142
Error	blocks	LeftCurly	'{' should be on a new line.	142
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	147
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	152

org/apache/archiva/metadata/repository/jcr/OakRepositoryFactory.java

Severity	Category	Rule	Message	Line
Error	extension	TreeWalker	Got an exception - expecting EOF, found '}'	181

org/apache/archiva/metadata/repository/stats/JcrRepositoryStatisticsGatheringTest.java

Severity	Category	Rule	Message	Line
Error	extension	TreeWalker	Got an exception - expecting EOF, found 'logger'	261