Checkstyle Results

The following document contains the results of Checkstyle 5.7. 

Summary

Files	Info	Warnings	Errors
13	8	71	62

Files

File	I	W	E
org/apache/archiva/security/AbstractSecurityTest.java	8	4	16
org/apache/archiva/security/AccessDeniedException.java	0	2	0
org/apache/archiva/security/ArchivaSecurityException.java	0	2	0
org/apache/archiva/security/ArchivaServletAuthenticator.java	0	2	1
org/apache/archiva/security/ArchivaServletAuthenticatorTest.java	0	11	6
org/apache/archiva/security/ArchivaStandardRolesCheck.java	0	0	4
org/apache/archiva/security/DefaultUserRepositories.java	0	4	20
org/apache/archiva/security/DefaultUserRepositoriesTest.java	0	1	1
org/apache/archiva/security/PrincipalNotFoundException.java	0	2	0
org/apache/archiva/security/RoleManagerTest.java	0	1	0
org/apache/archiva/security/ServletAuthenticator.java	0	18	0
org/apache/archiva/security/UserRepositories.java	0	24	11
org/apache/archiva/security/mock/MockBeanServices.java	0	0	3

Rules

Category	Rule	Violations	Severity
blocks	LeftCurly option: "nl"	1	Error
	RightCurly option: "alone"	1	Error
coding	RedundantThrows	24	Error
header	RegexpHeader fileExtensions: "java" headerFile: "target/checkstyle-header.txt"	1	Error
imports	AvoidStarImport	1	Error
javadoc	JavadocMethod scope: "protected"	71	Warning
	JavadocVariable scope: "protected"	8	Info
sizes	LineLength max: "120" ignorePattern: "@version|@see|@todo|TODO"	2	Error
whitespace	ParenPad option: "space"	31	Error
	WhitespaceAfter	1	Error

Details

org/apache/archiva/security/AbstractSecurityTest.java

Severity	Category	Rule	Message	Line
Error	whitespace	ParenPad	'(' is not followed by whitespace.	54
Error	whitespace	ParenPad	')' is not preceded with whitespace.	54
Error	whitespace	ParenPad	'(' is not followed by whitespace.	55
Error	whitespace	ParenPad	')' is not preceded with whitespace.	55
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	60
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	62
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	64
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	66
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	68
Error	whitespace	ParenPad	'(' is not followed by whitespace.	69
Error	whitespace	ParenPad	')' is not preceded with whitespace.	69
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	72
Error	whitespace	ParenPad	'(' is not followed by whitespace.	73
Error	whitespace	ParenPad	')' is not preceded with whitespace.	73
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	76
Error	whitespace	ParenPad	'(' is not followed by whitespace.	80
Error	whitespace	ParenPad	')' is not preceded with whitespace.	80
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	86
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	89
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	106
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	112
Error	whitespace	ParenPad	'(' is not followed by whitespace.	135
Error	whitespace	ParenPad	')' is not preceded with whitespace.	135
Error	whitespace	ParenPad	'(' is not followed by whitespace.	136
Error	whitespace	ParenPad	')' is not preceded with whitespace.	136
Error	whitespace	ParenPad	'(' is not followed by whitespace.	155
Error	whitespace	ParenPad	')' is not preceded with whitespace.	155
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	159

org/apache/archiva/security/AccessDeniedException.java

Severity	Category	Rule	Message	Line
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	30
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	35

org/apache/archiva/security/ArchivaSecurityException.java

Severity	Category	Rule	Message	Line
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	32
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	37

org/apache/archiva/security/ArchivaServletAuthenticator.java

Severity	Category	Rule	Message	Line
Error	blocks	RightCurly	'}' should be alone on a line.	122
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	130
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	135

org/apache/archiva/security/ArchivaServletAuthenticatorTest.java

Severity	Category	Rule	Message	Line
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	66
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	72
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	82
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	98
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	120
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	155
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	177
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	202
Error	whitespace	ParenPad	'(' is not followed by whitespace.	213
Error	whitespace	ParenPad	')' is not preceded with whitespace.	213
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	217
Error	whitespace	ParenPad	'(' is not followed by whitespace.	228
Error	whitespace	ParenPad	')' is not preceded with whitespace.	228
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	232
Error	whitespace	ParenPad	'(' is not followed by whitespace.	244
Error	whitespace	ParenPad	')' is not preceded with whitespace.	244
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	247

org/apache/archiva/security/ArchivaStandardRolesCheck.java

Severity	Category	Rule	Message	Line
Error	whitespace	ParenPad	'(' is not followed by whitespace.	37
Error	whitespace	ParenPad	')' is not preceded with whitespace.	37
Error	whitespace	ParenPad	'(' is not followed by whitespace.	47
Error	whitespace	ParenPad	')' is not preceded with whitespace.	47

org/apache/archiva/security/DefaultUserRepositories.java

Severity	Category	Rule	Message	Line
Error	coding	RedundantThrows	Redundant throws: 'PrincipalNotFoundException' is subclass of 'ArchivaSecurityException'.	65
Error	coding	RedundantThrows	Redundant throws: 'AccessDeniedException' is subclass of 'ArchivaSecurityException'.	65
Error	coding	RedundantThrows	Redundant throws: 'PrincipalNotFoundException' is subclass of 'ArchivaSecurityException'.	74
Error	coding	RedundantThrows	Redundant throws: 'AccessDeniedException' is subclass of 'ArchivaSecurityException'.	74
Error	coding	RedundantThrows	Redundant throws: 'AccessDeniedException' is subclass of 'ArchivaSecurityException'.	82
Error	coding	RedundantThrows	Redundant throws: 'PrincipalNotFoundException' is subclass of 'ArchivaSecurityException'.	82
Error	coding	RedundantThrows	Redundant throws: 'AccessDeniedException' is subclass of 'ArchivaSecurityException'.	97
Error	coding	RedundantThrows	Redundant throws: 'PrincipalNotFoundException' is subclass of 'ArchivaSecurityException'.	97
Error	sizes	LineLength	Line is longer than 120 characters (found 162).	103
Error	whitespace	ParenPad	'(' is not followed by whitespace.	103
Error	whitespace	ParenPad	')' is not preceded with whitespace.	103
Error	coding	RedundantThrows	Redundant throws: 'AccessDeniedException' is subclass of 'ArchivaSecurityException'.	103
Error	coding	RedundantThrows	Redundant throws: 'PrincipalNotFoundException' is subclass of 'ArchivaSecurityException'.	103
Error	blocks	LeftCurly	'{' should be on a new line.	103
Error	coding	RedundantThrows	Redundant throws: 'AccessDeniedException' is subclass of 'ArchivaSecurityException'.	108
Error	coding	RedundantThrows	Redundant throws: 'PrincipalNotFoundException' is subclass of 'ArchivaSecurityException'.	108
Error	coding	RedundantThrows	Redundant throws: 'AccessDeniedException' is subclass of 'ArchivaSecurityException'.	147
Error	coding	RedundantThrows	Redundant throws: 'PrincipalNotFoundException' is subclass of 'ArchivaSecurityException'.	203
Error	whitespace	ParenPad	')' is not preceded with whitespace.	215
Error	whitespace	ParenPad	')' is not preceded with whitespace.	233
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	237
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	242
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	247
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	252

org/apache/archiva/security/DefaultUserRepositoriesTest.java

Severity	Category	Rule	Message	Line
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	51
Error	whitespace	WhitespaceAfter	',' is not followed by whitespace.	76

org/apache/archiva/security/PrincipalNotFoundException.java

Severity	Category	Rule	Message	Line
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	30
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	35

org/apache/archiva/security/RoleManagerTest.java

Severity	Category	Rule	Message	Line
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	45

org/apache/archiva/security/ServletAuthenticator.java

Severity	Category	Rule	Message	Line
Warning	javadoc	JavadocMethod	Expected an @return tag.	47
Warning	javadoc	JavadocMethod	Expected @param tag for 'request'.	47
Warning	javadoc	JavadocMethod	Expected @param tag for 'result'.	47
Warning	javadoc	JavadocMethod	Expected @throws tag for 'AuthenticationException'.	48
Warning	javadoc	JavadocMethod	Expected @throws tag for 'AccountLockedException'.	48
Warning	javadoc	JavadocMethod	Expected @throws tag for 'MustChangePasswordException'.	48
Warning	javadoc	JavadocMethod	Expected an @return tag.	61
Warning	javadoc	JavadocMethod	Expected @param tag for 'request'.	61
Warning	javadoc	JavadocMethod	Expected @param tag for 'securitySession'.	61
Warning	javadoc	JavadocMethod	Expected @param tag for 'repositoryId'.	61
Warning	javadoc	JavadocMethod	Expected @param tag for 'permission'.	62
Warning	javadoc	JavadocMethod	Expected @throws tag for 'AuthorizationException'.	62
Warning	javadoc	JavadocMethod	Expected @throws tag for 'UnauthorizedException'.	62
Warning	javadoc	JavadocMethod	Expected an @return tag.	77
Warning	javadoc	JavadocMethod	Expected @param tag for 'principal'.	77
Warning	javadoc	JavadocMethod	Expected @param tag for 'repoId'.	77
Warning	javadoc	JavadocMethod	Expected @param tag for 'permission'.	77
Warning	javadoc	JavadocMethod	Expected @throws tag for 'UnauthorizedException'.	78

org/apache/archiva/security/UserRepositories.java

Severity	Category	Rule	Message	Line
Warning	javadoc	JavadocMethod	Expected @throws tag for 'PrincipalNotFoundException'.	43
Error	coding	RedundantThrows	Redundant throws: 'PrincipalNotFoundException' is subclass of 'ArchivaSecurityException'.	43
Warning	javadoc	JavadocMethod	Expected @throws tag for 'AccessDeniedException'.	43
Error	coding	RedundantThrows	Redundant throws: 'AccessDeniedException' is subclass of 'ArchivaSecurityException'.	43
Warning	javadoc	JavadocMethod	Expected @throws tag for 'ArchivaSecurityException'.	43
Warning	javadoc	JavadocMethod	Expected @throws tag for 'PrincipalNotFoundException'.	55
Error	coding	RedundantThrows	Redundant throws: 'PrincipalNotFoundException' is subclass of 'ArchivaSecurityException'.	55
Warning	javadoc	JavadocMethod	Expected @throws tag for 'AccessDeniedException'.	55
Error	coding	RedundantThrows	Redundant throws: 'AccessDeniedException' is subclass of 'ArchivaSecurityException'.	55
Warning	javadoc	JavadocMethod	Expected @throws tag for 'ArchivaSecurityException'.	55
Warning	javadoc	JavadocMethod	Expected an @return tag.	75
Warning	javadoc	JavadocMethod	Expected @param tag for 'principal'.	75
Warning	javadoc	JavadocMethod	Expected @param tag for 'repoId'.	75
Error	whitespace	ParenPad	')' is not preceded with whitespace.	75
Warning	javadoc	JavadocMethod	Expected @throws tag for 'PrincipalNotFoundException'.	76
Error	coding	RedundantThrows	Redundant throws: 'PrincipalNotFoundException' is subclass of 'ArchivaSecurityException'.	76
Warning	javadoc	JavadocMethod	Expected @throws tag for 'ArchivaSecurityException'.	76
Warning	javadoc	JavadocMethod	Expected an @return tag.	87
Warning	javadoc	JavadocMethod	Expected @param tag for 'principal'.	87
Warning	javadoc	JavadocMethod	Expected @param tag for 'repoId'.	87
Error	coding	RedundantThrows	Redundant throws: 'AccessDeniedException' is subclass of 'ArchivaSecurityException'.	88
Warning	javadoc	JavadocMethod	Expected an @return tag.	99
Warning	javadoc	JavadocMethod	Expected @param tag for 'principal'.	99
Warning	javadoc	JavadocMethod	Expected @throws tag for 'ArchivaSecurityException'.	100
Warning	javadoc	JavadocMethod	Expected @throws tag for 'AccessDeniedException'.	100
Error	coding	RedundantThrows	Redundant throws: 'AccessDeniedException' is subclass of 'ArchivaSecurityException'.	100
Warning	javadoc	JavadocMethod	Expected @throws tag for 'PrincipalNotFoundException'.	100
Error	coding	RedundantThrows	Redundant throws: 'PrincipalNotFoundException' is subclass of 'ArchivaSecurityException'.	100
Warning	javadoc	JavadocMethod	Expected an @return tag.	113
Warning	javadoc	JavadocMethod	Expected @param tag for 'principal'.	113
Warning	javadoc	JavadocMethod	Expected @throws tag for 'ArchivaSecurityException'.	114
Warning	javadoc	JavadocMethod	Expected @throws tag for 'AccessDeniedException'.	114
Error	coding	RedundantThrows	Redundant throws: 'AccessDeniedException' is subclass of 'ArchivaSecurityException'.	114
Warning	javadoc	JavadocMethod	Expected @throws tag for 'PrincipalNotFoundException'.	114
Error	coding	RedundantThrows	Redundant throws: 'PrincipalNotFoundException' is subclass of 'ArchivaSecurityException'.	114

org/apache/archiva/security/mock/MockBeanServices.java

Severity	Category	Rule	Message	Line
Error	header	RegexpHeader	Line does not match expected header line of '^\s*$'.	2
Error	imports	AvoidStarImport	Using the '.*' form of import should be avoided - org.apache.archiva.metadata.repository.storage.*.	27
Error	sizes	LineLength	Line is longer than 120 characters (found 167).	167