Checkstyle Results

The following document contains the results of Checkstyle 5.7. 

Summary

Files	Info	Warnings	Errors
11	4	24	154

Files

File	I	W	E
org/apache/archiva/xml/AbstractArchivaXmlTestCase.java	4	1	7
org/apache/archiva/xml/LatinEntities.java	0	1	1
org/apache/archiva/xml/LatinEntitiesTest.java	0	1	0
org/apache/archiva/xml/LatinEntityResolutionReader.java	0	1	0
org/apache/archiva/xml/LatinEntityResolutionReaderTest.java	0	6	8
org/apache/archiva/xml/XMLException.java	0	2	0
org/apache/archiva/xml/XMLReader.java	0	0	1
org/apache/archiva/xml/XMLReaderTest.java	0	5	1
org/apache/archiva/xml/XMLWriter.java	0	0	61
org/apache/archiva/xml/XMLWriterTest.java	0	1	18
org/apache/archiva/xml/XmlUtil.java	0	6	57

Rules

Category	Rule	Violations	Severity
blocks	LeftCurly option: "nl"	28	Error
	RightCurly option: "alone"	8	Error
coding	MagicNumber ignoreNumbers: "-4, -3, -2, -1, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 31, 32, 37, 64, 100, 128, 256, 512, 1000, 1024"	3	Error
imports	AvoidStarImport	1	Error
	UnusedImports	5	Error
javadoc	JavadocMethod scope: "protected"	24	Warning
	JavadocType allowUnknownTags: "true" scope: "protected"	1	Error
	JavadocVariable scope: "protected"	4	Info
naming	ConstantName	1	Error
whitespace	ParenPad option: "space"	98	Error
	WhitespaceAround	8	Error

Details

org/apache/archiva/xml/AbstractArchivaXmlTestCase.java

Severity	Category	Rule	Message	Line
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	39
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	41
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	43
Info	javadoc	JavadocVariable	Missing a Javadoc comment.	45
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	47
Error	whitespace	ParenPad	'(' is not followed by whitespace.	47
Error	whitespace	ParenPad	'(' is not followed by whitespace.	49
Error	whitespace	ParenPad	')' is not preceded with whitespace.	49
Error	whitespace	ParenPad	'(' is not followed by whitespace.	50
Error	whitespace	ParenPad	')' is not preceded with whitespace.	50
Error	whitespace	ParenPad	'(' is not followed by whitespace.	55
Error	whitespace	ParenPad	')' is not preceded with whitespace.	55

org/apache/archiva/xml/LatinEntities.java

Severity	Category	Rule	Message	Line
Error	naming	ConstantName	Name 'defaultEntityMap' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.	32
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	298

org/apache/archiva/xml/LatinEntitiesTest.java

Severity	Category	Rule	Message	Line
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	36

org/apache/archiva/xml/LatinEntityResolutionReader.java

Severity	Category	Rule	Message	Line
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	42

org/apache/archiva/xml/LatinEntityResolutionReaderTest.java

Severity	Category	Rule	Message	Line
Error	imports	UnusedImports	Unused import - org.junit.Assert.	22
Error	imports	UnusedImports	Unused import - java.io.InputStream.	28
Error	imports	UnusedImports	Unused import - java.io.InputStreamReader.	29
Error	imports	UnusedImports	Unused import - java.net.URL.	32
Error	imports	UnusedImports	Unused import - java.nio.charset.Charset.	33
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	102
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	141
Error	coding	MagicNumber	'4096' is a magic number.	154
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	157
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	173
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	189
Error	coding	MagicNumber	'409600' is a magic number.	202
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	206
Error	coding	MagicNumber	'4096' is a magic number.	209

org/apache/archiva/xml/XMLException.java

Severity	Category	Rule	Message	Line
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	31
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	36

org/apache/archiva/xml/XMLReader.java

Severity	Category	Rule	Message	Line
Error	extension	TreeWalker	Got an exception - expecting EOF, found '}'	342

org/apache/archiva/xml/XMLReaderTest.java

Severity	Category	Rule	Message	Line
Error	whitespace	ParenPad	')' is not preceded with whitespace.	45
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	55
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	66
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	77
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	88
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	100

org/apache/archiva/xml/XMLWriter.java

Severity	Category	Rule	Message	Line
Error	blocks	LeftCurly	'{' should be on a new line.	36
Error	whitespace	ParenPad	'(' is not followed by whitespace.	44
Error	whitespace	ParenPad	')' is not preceded with whitespace.	44
Error	blocks	LeftCurly	'{' should be on a new line.	45
Error	whitespace	ParenPad	'(' is not followed by whitespace.	46
Error	whitespace	ParenPad	')' is not preceded with whitespace.	46
Error	whitespace	ParenPad	'(' is not followed by whitespace.	57
Error	whitespace	ParenPad	')' is not preceded with whitespace.	57
Error	blocks	LeftCurly	'{' should be on a new line.	58
Error	blocks	LeftCurly	'{' should be on a new line.	60
Error	whitespace	ParenPad	'(' is not followed by whitespace.	63
Error	whitespace	ParenPad	')' is not preceded with whitespace.	63
Error	blocks	LeftCurly	'{' should be on a new line.	64
Error	whitespace	ParenPad	'(' is not followed by whitespace.	65
Error	whitespace	ParenPad	')' is not preceded with whitespace.	65
Error	blocks	RightCurly	'}' should be alone on a line.	66
Error	whitespace	ParenPad	'(' is not followed by whitespace.	66
Error	whitespace	ParenPad	')' is not preceded with whitespace.	66
Error	blocks	LeftCurly	'{' should be on a new line.	66
Error	whitespace	ParenPad	'(' is not followed by whitespace.	70
Error	whitespace	ParenPad	')' is not preceded with whitespace.	70
Error	whitespace	ParenPad	'(' is not followed by whitespace.	71
Error	whitespace	ParenPad	')' is not preceded with whitespace.	71
Error	whitespace	ParenPad	'(' is not followed by whitespace.	72
Error	whitespace	ParenPad	')' is not preceded with whitespace.	72
Error	whitespace	ParenPad	'(' is not followed by whitespace.	73
Error	whitespace	ParenPad	')' is not preceded with whitespace.	73
Error	whitespace	ParenPad	'(' is not followed by whitespace.	74
Error	whitespace	ParenPad	')' is not preceded with whitespace.	74
Error	blocks	RightCurly	'}' should be alone on a line.	77
Error	whitespace	ParenPad	'(' is not followed by whitespace.	77
Error	whitespace	ParenPad	')' is not preceded with whitespace.	77
Error	blocks	LeftCurly	'{' should be on a new line.	77
Error	whitespace	ParenPad	'(' is not followed by whitespace.	78
Error	whitespace	ParenPad	')' is not preceded with whitespace.	78
Error	blocks	RightCurly	'}' should be alone on a line.	79
Error	whitespace	ParenPad	'(' is not followed by whitespace.	79
Error	whitespace	ParenPad	')' is not preceded with whitespace.	79
Error	blocks	LeftCurly	'{' should be on a new line.	79
Error	whitespace	ParenPad	'(' is not followed by whitespace.	80
Error	whitespace	ParenPad	')' is not preceded with whitespace.	80
Error	blocks	RightCurly	'}' should be alone on a line.	81
Error	blocks	LeftCurly	'{' should be on a new line.	81
Error	whitespace	ParenPad	'(' is not followed by whitespace.	82
Error	whitespace	WhitespaceAround	'!=' is not preceded with whitespace.	82
Error	whitespace	WhitespaceAround	'!=' is not followed by whitespace.	82
Error	whitespace	ParenPad	')' is not preceded with whitespace.	82
Error	blocks	LeftCurly	'{' should be on a new line.	82
Error	whitespace	ParenPad	'(' is not followed by whitespace.	83
Error	whitespace	ParenPad	')' is not preceded with whitespace.	83
Error	blocks	LeftCurly	'{' should be on a new line.	83
Error	blocks	LeftCurly	'{' should be on a new line.	84
Error	blocks	RightCurly	'}' should be alone on a line.	86
Error	whitespace	ParenPad	'(' is not followed by whitespace.	86
Error	whitespace	ParenPad	')' is not preceded with whitespace.	86
Error	blocks	LeftCurly	'{' should be on a new line.	86
Error	blocks	LeftCurly	'{' should be on a new line.	89
Error	blocks	RightCurly	'}' should be alone on a line.	91
Error	whitespace	ParenPad	'(' is not followed by whitespace.	91
Error	whitespace	ParenPad	')' is not preceded with whitespace.	91
Error	blocks	LeftCurly	'{' should be on a new line.	91

org/apache/archiva/xml/XMLWriterTest.java

Severity	Category	Rule	Message	Line
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	38
Error	whitespace	ParenPad	'(' is not followed by whitespace.	54
Error	whitespace	ParenPad	')' is not preceded with whitespace.	54
Error	whitespace	ParenPad	'(' is not followed by whitespace.	55
Error	whitespace	ParenPad	')' is not preceded with whitespace.	55
Error	whitespace	ParenPad	'(' is not followed by whitespace.	57
Error	whitespace	ParenPad	')' is not preceded with whitespace.	57
Error	whitespace	ParenPad	'(' is not followed by whitespace.	58
Error	whitespace	ParenPad	')' is not preceded with whitespace.	58
Error	whitespace	ParenPad	'(' is not followed by whitespace.	59
Error	whitespace	ParenPad	')' is not preceded with whitespace.	59
Error	whitespace	ParenPad	'(' is not followed by whitespace.	60
Error	whitespace	ParenPad	')' is not preceded with whitespace.	60
Error	whitespace	ParenPad	'(' is not followed by whitespace.	61
Error	whitespace	ParenPad	')' is not preceded with whitespace.	61
Error	whitespace	ParenPad	'(' is not followed by whitespace.	62
Error	whitespace	ParenPad	')' is not preceded with whitespace.	62
Error	whitespace	ParenPad	'(' is not followed by whitespace.	64
Error	whitespace	ParenPad	')' is not preceded with whitespace.	64

org/apache/archiva/xml/XmlUtil.java

Severity	Category	Rule	Message	Line
Error	imports	AvoidStarImport	Using the '.*' form of import should be avoided - org.w3c.dom.*.	22
Error	javadoc	JavadocType	Missing a Javadoc comment.	28
Error	blocks	LeftCurly	'{' should be on a new line.	28
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	31
Error	blocks	LeftCurly	'{' should be on a new line.	31
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	37
Error	whitespace	ParenPad	'(' is not followed by whitespace.	37
Error	whitespace	ParenPad	')' is not preceded with whitespace.	37
Error	blocks	LeftCurly	'{' should be on a new line.	37
Error	whitespace	ParenPad	'(' is not followed by whitespace.	38
Error	whitespace	ParenPad	')' is not preceded with whitespace.	38
Error	whitespace	ParenPad	'(' is not followed by whitespace.	39
Error	whitespace	ParenPad	')' is not preceded with whitespace.	39
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	43
Error	whitespace	ParenPad	'(' is not followed by whitespace.	43
Error	whitespace	ParenPad	')' is not preceded with whitespace.	43
Error	blocks	LeftCurly	'{' should be on a new line.	43
Error	whitespace	ParenPad	'(' is not followed by whitespace.	45
Error	whitespace	ParenPad	')' is not preceded with whitespace.	45
Error	whitespace	ParenPad	'(' is not followed by whitespace.	46
Error	whitespace	ParenPad	')' is not preceded with whitespace.	46
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	50
Error	whitespace	ParenPad	'(' is not followed by whitespace.	50
Error	whitespace	ParenPad	')' is not preceded with whitespace.	50
Error	blocks	LeftCurly	'{' should be on a new line.	50
Error	whitespace	ParenPad	'(' is not followed by whitespace.	51
Error	whitespace	WhitespaceAround	'!=' is not preceded with whitespace.	51
Error	whitespace	WhitespaceAround	'!=' is not followed by whitespace.	51
Error	whitespace	ParenPad	')' is not preceded with whitespace.	51
Error	blocks	LeftCurly	'{' should be on a new line.	51
Error	blocks	LeftCurly	'{' should be on a new line.	53
Error	whitespace	ParenPad	'(' is not followed by whitespace.	55
Error	whitespace	WhitespaceAround	'!=' is not preceded with whitespace.	55
Error	whitespace	WhitespaceAround	'!=' is not followed by whitespace.	55
Error	whitespace	ParenPad	')' is not preceded with whitespace.	55
Error	blocks	LeftCurly	'{' should be on a new line.	55
Error	blocks	RightCurly	'}' should be alone on a line.	58
Error	whitespace	ParenPad	'(' is not followed by whitespace.	58
Error	whitespace	ParenPad	')' is not preceded with whitespace.	58
Error	blocks	LeftCurly	'{' should be on a new line.	58
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	65
Error	whitespace	ParenPad	'(' is not followed by whitespace.	65
Error	whitespace	ParenPad	')' is not preceded with whitespace.	65
Error	blocks	LeftCurly	'{' should be on a new line.	65
Error	whitespace	ParenPad	'(' is not followed by whitespace.	66
Error	whitespace	ParenPad	')' is not preceded with whitespace.	66
Error	whitespace	ParenPad	'(' is not followed by whitespace.	67
Error	whitespace	WhitespaceAround	'>' is not preceded with whitespace.	67
Error	whitespace	WhitespaceAround	'>' is not followed by whitespace.	67
Error	whitespace	ParenPad	')' is not preceded with whitespace.	67
Error	blocks	LeftCurly	'{' should be on a new line.	67
Error	whitespace	ParenPad	'(' is not followed by whitespace.	68
Error	whitespace	ParenPad	')' is not preceded with whitespace.	68
Error	blocks	RightCurly	'}' should be alone on a line.	69
Error	blocks	LeftCurly	'{' should be on a new line.	69
Warning	javadoc	JavadocMethod	Missing a Javadoc comment.	74
Error	whitespace	ParenPad	'(' is not followed by whitespace.	74
Error	whitespace	ParenPad	')' is not preceded with whitespace.	74
Error	blocks	LeftCurly	'{' should be on a new line.	74
Error	whitespace	ParenPad	'(' is not followed by whitespace.	75
Error	whitespace	ParenPad	'(' is not followed by whitespace.	75
Error	whitespace	ParenPad	')' is not preceded with whitespace.	75
Error	whitespace	ParenPad	')' is not preceded with whitespace.	75